Corrections to cell-averaged density computation #213

iangrooms · 2022-03-29T21:03:24Z

This PR builds on mom-ocean#1156 and mom-ocean#1209, implementing a correction to the computation of cell-averaged density in various parts of the model. A description of the parameterization and results can be found in these papers.

The main updates in this PR are the ability to use a new stochastic version of the correction, and the ability to turn on the density correction in the calculation of the mixed layer lateral density gradient in the mixed layer restratification parameterization.
In addition, the code related to this parameterization has been re-factored a bit, along with some small bug fixes.

The parameterization can be toggled on/off in different parts of the code using the following flags:

USE_STANLEY_PGF turns it on in computation of the pressure gradient force
USE_STANLEY_ML turns it on in the mixed layer restratification parameterization
USE_STANLEY_ISO turns it on in the computation of isopycnal slopes in MOM_isopycnal_slopes.F90. This doesn't necessarily turn it on in MOM_thickness_diffuse.F90 though, since MOM_thickness_diffuse.F90 sometimes computes its own isopycnal slopes. See below

USE_STANLEY_GM turns it on in the computation of isopycnal slopes in GM. Specifically, it sets use_stanley to .TRUE. in these lines of MOM_thickness_diffuse.F90

MOM6/src/parameterizations/lateral/MOM_thickness_diffuse.F90

Lines 797 to 798 in 3d62428

    
           calc_derivatives = use_EOS .and. (k >= nk_linear) .and. & 
        
              (find_work .or. .not. present_slope_x .or. CS%use_FGNV_streamfn .or. use_stanley)

.

The tunable coefficients of the parameterization are controlled by

STANLEY_COEFF this is the main tunable coefficient, denoted c in the papers linked above. The SGS temperature variance is parameterized as c times squared temperature differences.
STANLEY_A allows you to tune the amplitude of the noise in the stochastic version. The multiplicative noise is exp(a * chi). With a default of 1.0 you get the stochastic parameterization described in the papers. With a value of 0.0 you get a deterministic parameterization.

Update to GFDL master

Brankart

Dev/gfdl

merge Brankart

…parameterization.

…an deterministic) Stanley SGS T variance parameterization.

…ern in MOM_PressureForce_FV, when deterministic parameterization is on.

Stoch eos

Add stochastic component to MOM_thickness_diffuse

fix array size declaration and post_data

…chastic) is switched on in PGF and thickness diffusion codes

…leanup (#19) * Test Stanley EOS param in mixed_layer_restrat * Fix size of TS cov, S var in Stanley calculate_density calls * Test move stanley scheme initialization * Added missing openMP directives * Revert Stanley tvar discretization (#18) * Perform vertical filling in calculation of T variance * Variable declaration syntax error, remove scaling from get_param * Fix call to vert_fill_TS * Code cleanup, whitespace cleanup Co-authored-by: Jessica Kenigson <[email protected]>

Use Stanley (2020) variance; scheme off at coast

Change start indices in stanley_density_1d

Stanley param in MOM_isopycnal_slopes and thickness diffuse index fix

Pull in Jessica's isopycnal slope code

gustavo-marques · 2022-05-07T17:59:31Z

Passing tests in mom_aux and Cheyenne-MOM6-examples.

MOM_input parameters added:

USE_STANLEY_ISO = False         !   [Boolean] default = False
                                ! If true, turn on Stanley SGS T variance parameterization in isopycnal slope
                                ! code.

USE_STANLEY_GM = False          !   [Boolean] default = False
                                ! If true, turn on Stanley SGS T variance parameterization in GM code.

STOCH_EOS = False               !   [Boolean] default = False
                                ! If true, stochastic perturbations are applied to the EOS in the PGF.

STANLEY_COEFF = -1.0            !   [not defined] default = -1.0
                                ! Coefficient correlating the temperature gradient and SGS T variance.

STANLEY_A = 1.0                 !   [not defined] default = 1.0
                                ! Coefficient a which scales chi in stochastic perturbation of the SGS T
                                ! variance.

USE_STANLEY_PGF = False         !   [Boolean] default = False
                               ! If true, turn on Stanley SGS T variance parameterization in PGF code.

USE_STANLEY_ML = False          !   [Boolean] default = False
                                ! If true, turn on Stanley SGS T variance parameterization in ML restrat code.

MOM_input parameters there were removed:

STANLEY_PRM_DET_COEFF = -1.0    !   [nondim] default = -1.0
                                ! The coefficient correlating SGS temperature variance with the mean temperature
                                ! gradient in the deterministic part of the Stanley parameterization. Negative
                                ! values disable the scheme.

PGF_STANLEY_T2_DET_COEFF = -1.0 !   [nondim] default = -1.0
                                ! The coefficient correlating SGS temperature variance with the mean temperature
                                ! gradient in the deterministic part of the Stanley form of the Brankart
                                ! correction. Negative values disable the scheme.

pjpegion and others added 30 commits July 30, 2020 12:55

Merge pull request #2 from NOAA-GFDL/dev/gfdl

b96be91

Update to GFDL master

initial hooks for stochastic EOS modifications

52d5d37

Merge pull request #3 from adcroft/brankart

e65ab13

Brankart

Merge pull request #4 from pjpegion/dev/gfdl

6d05360

Dev/gfdl

remove debug statements

26d4370

add documentation

65f8cb0

Change ampltiude from 0.39 to sqrt(.39)

8267b23

remove global_indexing logic from stoch_eos_init

5877b03

switch to using MOM_random and add restart capability

5da4034

update random sequence to update each each time-step

d117670

remove tseed0 from MOM_random (leftover from debugging)

d9286df

Merge pull request #7 from adcroft/brankart

576dd73

merge Brankart

Added necessary submodules and S^2, T^2 diagnostics to MOM_diagnostics

9a6b5fa

Added diagnostics for outputting variables related to the stochastic …

9f64941

…parameterization.

Diagnostics in MOM_PressureForce_FV updated for stochastic (rather th…

363871a

…an deterministic) Stanley SGS T variance parameterization.

Added parentheses for reproducibility.

d039cd6

Changed diagnostics to account for possible absence of stoch_eos_patt…

c6a12ce

…ern in MOM_PressureForce_FV, when deterministic parameterization is on.

Merge pull request #10 from jskenigson/stoch_eos

eb04417

Stoch eos

Merge branch 'dev/ncar' into stoch_eos_ncar

baec71a

remove mom6_da_hooks and geoKdTree from pkg

885d144

add stochastic compoment to MOM_thickness_diffuse

319b8bf

Merge pull request #2 from pjpegion/stoch_eos

51e0d97

Add stochastic component to MOM_thickness_diffuse

fix array size declaration and post_data

7838819

Merge pull request #4 from pjpegion/stoch_eos

7356912

fix array size declaration and post_data

Corrected indexing of loops in MOM_calc_varT

2bedd49

Changed how parameterization of SGS T variance (deterministic and sto…

8758ad4

…chastic) is switched on in PGF and thickness diffusion codes

Corrected a few typos

2b9c226

Cleaned up indices, redundant diagnostic, printing

33d9e24

Fixed diagnostic IDs

36cdff0

Fixed diagnostics typo

3584e3f

jskenigson and others added 26 commits August 3, 2021 09:33

Use Stanley (2020) variance; scheme off at coast

03c064d

Comment clean-up

a3f36ee

Remove factor of 0.5 in Tvar

56d1e9c

Merge pull request #20 from jskenigson/stoch_eos_stanley_var

808cde2

Use Stanley (2020) variance; scheme off at coast

Don't calculate Stanley diagnostics on halo

4b22ba6

Change start indices in stanley_density_1d

6628d88

Merge pull request #21 from jskenigson/stoch_eos_dev_rho_bug_fix

d0126a5

Change start indices in stanley_density_1d

Stanley param in MOM_isopycnal_slopes (#22)

937d56a

Stanley param in MOM_isopycnal_slopes and thickness diffuse index fix

Set eady flag to true if use_stored_slopes is true

524d03c

Cleanup, docs, whitespace

9c39403

Docs and whitespace

e7a3120

Docs and whitespace

5c1e2d8

Docs and whitespace

cdff597

Whitespace cleanup

d40f4a5

Whitespace cleanup

b4a587e

Clean up whitespace

8522dc3

Merge branch 'stoch_eos_dev_slopes' into stoch_eos_dev_slopes

9f1e4c3

Merge pull request #2 from jskenigson/stoch_eos_dev_slopes

babada7

Pull in Jessica's isopycnal slope code

Docs cleanup

a94841f

Merge branch 'dev/ncar' into stoch_eos_dev_slopes

6fb13ca

use_stanley

cab9508

Update MOM_lateral_mixing_coeffs.F90

cdd17dd

Adds link to another TEOS10 module

1d39028

Set Stanley off for testing

46ce517

Line continuation

3d62428

gustavo-marques self-requested a review May 5, 2022 22:37

gustavo-marques merged commit 8f97b3d into NCAR:dev/ncar May 7, 2022

gustavo-marques mentioned this pull request Jun 3, 2022

NCAR to main candidate branch (2022-06-03) mom-ocean/MOM6#1571

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Corrections to cell-averaged density computation #213

Corrections to cell-averaged density computation #213

iangrooms commented Mar 29, 2022 •

edited

Loading

gustavo-marques commented May 7, 2022

	calc_derivatives = use_EOS .and. (k >= nk_linear) .and. &
	(find_work .or. .not. present_slope_x .or. CS%use_FGNV_streamfn .or. use_stanley)

Corrections to cell-averaged density computation #213

Corrections to cell-averaged density computation #213

Conversation

iangrooms commented Mar 29, 2022 • edited Loading

gustavo-marques commented May 7, 2022

iangrooms commented Mar 29, 2022 •

edited

Loading